Fix #13767 (SymbolDatabase: refactorings. Remove always false condition. Make loop more robust)#7457
Merged
danmar merged 1 commit intocppcheck-opensource:mainfrom May 12, 2025
Conversation
danmar
force-pushed
the
refactor-findsimplematch
branch
from
5c3dc64 to
bbc72cb
Compare
danmar
commented
Apr 12, 2025
Collaborator
Author
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
I cannot provide a testcase. Just wanted to remove a redundant condition and make code more robust in case there is a edge case I can't reproduce.
danmar
changed the title
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
lib/symboldatabase.cpp:1803
- The removed condition appears redundant given the preceding match check; please confirm that this change does not inadvertently skip cases that might require handling.
if (!Token::Match(dimension.tok->previous(), "[<,]"))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.